Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction interpretations #1457

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Transaction interpretations #1457

merged 7 commits into from
Dec 28, 2023

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented Dec 21, 2023

Description and Related Issue(s)

resolves #1435

Additional Information

added NEXT_PUBLIC_TRANSACTION_INTERPRETATION_ENABLED variable to enable transaction interpretations

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@isstuev isstuev changed the title Fe 1435 Transaction interpretations Dec 21, 2023
@isstuev isstuev marked this pull request as ready for review December 22, 2023 08:32
@isstuev isstuev changed the title Transaction interpretations [WIP] Transaction interpretations Dec 25, 2023
@isstuev isstuev changed the title [WIP] Transaction interpretations Transaction interpretations Dec 26, 2023
@isstuev isstuev requested a review from tom2drum December 26, 2023 10:26
tom2drum
tom2drum requested changes Dec 27, 2023
View reviewed changes
configs/app/features/txInterpretation.ts Outdated Show resolved Hide resolved
docs/ENVS.md Outdated Show resolved Hide resolved
icons/action.svg Outdated Show resolved Hide resolved
stubs/tx.ts Outdated Show resolved Hide resolved
ui/tx/details/txDetailsActions/TxDetailsActionsWrapper.tsx Outdated Show resolved Hide resolved
ui/tx/TxDetails.tsx Outdated Show resolved Hide resolved
ui/tx/details/txDetailsActions/TxDetailsActionsFallback.tsx Outdated Show resolved Hide resolved
ui/tx/interpretation/TxInterpretation.tsx Outdated Show resolved Hide resolved
ui/tx/interpretation/TxInterpretation.tsx Show resolved Hide resolved
ui/tx/interpretation/TxInterpretation.tsx Show resolved Hide resolved
@isstuev isstuev requested a review from tom2drum December 27, 2023 20:32
@tom2drum tom2drum merged commit 6bccd6c into main Dec 28, 2023
10 checks passed
@tom2drum tom2drum deleted the fe-1435 branch December 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction interpretation
3 participants
@isstuev @tom2drum @ArminaAiren